ttim commented 7 years ago

I did some investigation and found that disabling any kind of parallelism for tests on travis greatly improves success rates for our tests. It doesn't feel like a good solution but I think it worth merging until we fix our tests properly. Right now it's almost impossible to pass storm tests.

What do you think @pankajroark @johnynek ?

ttim commented 7 years ago

Bad part about this change - tests will take more time (travis containers have 2 cpus), but good part - they will actually start to pass.

codecov-io commented 7 years ago

Codecov Report

Merging #735 into develop will increase coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop    #735      +/-   ##
==========================================
+ Coverage    71.35%   71.4%   +0.05%     
==========================================
  Files          149     149              
  Lines         3627    3627              
  Branches       201     201              
==========================================
+ Hits          2588    2590       +2     
+ Misses        1039    1037       -2

Impacted Files	Coverage Δ
.../main/scala/com/twitter/summingbird/Producer.scala	`77.27% <0%> (+1.51%)`	:arrow_up:
...la/com/twitter/summingbird/scalding/TestUtil.scala	`49.12% <0%> (+1.75%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df1dfc3...0b91ded. Read the comment docs.

johnynek commented 7 years ago

nice work! Thanks for looking into this.

twitter / summingbird

Make travis CI more stable #735

Codecov Report