search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

Improve Producer equals methods #756

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

This is the same fix as here:

https://github.com/twitter/scalding/pull/1798

This fix is import for us due to some large graphs we have been constructing.

johnynek commented 6 years ago

quick look @ttim ?

codecov-io commented 6 years ago

Codecov Report

Merging #756 into develop will increase coverage by 0.28%. The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #756      +/-   ##
===========================================
+ Coverage     72.3%   72.58%   +0.28%     
===========================================
  Files          154      154              
  Lines         3759     3783      +24     
  Branches       206      211       +5     
===========================================
+ Hits          2718     2746      +28     
+ Misses        1041     1037       -4
Impacted Files Coverage Δ
.../main/scala/com/twitter/summingbird/Producer.scala 81.91% <92.85%> (+4.77%) :arrow_up:
...ain/scala/com/twitter/summingbird/TestGraphs.scala 87.26% <0%> (+1.91%) :arrow_up:
...a/com/twitter/summingbird/storm/StormTestRun.scala 66.66% <0%> (+6.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9d5bf0...c8e4ec7. Read the comment docs.

non commented 6 years ago

This looks reasonable to me. 👍