Make mergeBatched protected instead of private.

twitter / summingbird

Streaming MapReduce with Scalding and Storm

https://twitter.com/summingbird

Apache License 2.0

2.14k stars 267 forks source link

Make mergeBatched protected instead of private. #764

Open non opened 6 years ago

non commented 6 years ago

There are reasons why particular implementations might want to override this method (for example, to support custom serialization strategies), so let's make it protected instead of private.

johnynek commented 6 years ago

👍

Thanks!

merge when green.

johnynek commented 6 years ago

looks like this fails mima, naturally...

So we can make the change at the next mima break, maybe when we release for scalding 0.18

CLAassistant commented 4 years ago

All committers have signed the CLA.