search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

Provide `newVersion` in `modifyBeforeWrite` API #772

Closed ttim closed 5 years ago

ttim commented 5 years ago

As a follow up to https://github.com/twitter/summingbird/pull/771 we want also to provide newVersion as an argument to modifyBeforeWrite.

codecov-io commented 5 years ago

Codecov Report

Merging #772 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #772   +/-   ##
========================================
  Coverage    71.46%   71.46%           
========================================
  Files          151      151           
  Lines         3613     3613           
  Branches       209      209           
========================================
  Hits          2582     2582           
  Misses        1031     1031
Impacted Files Coverage Δ
...mmingbird/scalding/store/VersionedBatchStore.scala 59.25% <ø> (ø) :arrow_up:
...la/com/twitter/summingbird/scalding/TestUtil.scala 47.36% <0%> (-1.76%) :arrow_down:
.../main/scala/com/twitter/summingbird/Producer.scala 81.91% <0%> (+1.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cce6ca8...e10974d. Read the comment docs.