twitter / the-algorithm

Source code for Twitter's Recommendation Algorithm
https://blog.twitter.com/engineering/en_us/topics/open-source/2023/twitter-recommendation-algorithm
GNU Affero General Public License v3.0
62.33k stars 12.15k forks source link

The new X button doesn't close the website #1876

Open grumpycoderpt opened 1 year ago

grumpycoderpt commented 1 year ago

Describe the bug So a new close button popup today on the website and it doesn't work, instead of closing the website it redirects the user to the homepage. I know it is not regarding the algorithm but this place seemed appropriated to report a bug issue.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://www.twitter.com
  2. Click on top left X button
  3. See error

Expected behavior The tab should close, as good UX teach us.

Environment Windows Chrome latest version, also Mac OS and iOS 14 Safari.

Hydraulisch commented 1 year ago

STOP

BlackFrankFTM2 commented 1 year ago

got this issue too, here's hoping it gets resolved soon! 🙏

xrayian commented 1 year ago

It's always a delight to visit this repo

sreeniSudharsan commented 1 year ago

it's a new feature

abb128 commented 1 year ago

I got fed up waiting for a fix so I made a userscript that patches this as a temporary workaround. I haven't been able to test it thoroughly but hopefully someone finds it useful

https://greasyfork.org/en/scripts/471742-fix-x-button

bogzxo commented 1 year ago

twitter has official become unusable with these bugs…

abuseofnotation commented 1 year ago

Try :q!

Kusanalee commented 1 year ago

extremely concerning ‼️

mstdn commented 1 year ago

Twitter is one big bug these days

No solving that one

BidTheArt commented 1 year ago

Can confirm this bug also for Firefox ESR 115 on Debian GNU/Linux 12

tonytins commented 1 year ago

Knew this rebrand was going to screw everything over.

CleoMenezesJr commented 1 year ago

Any news about this? I had to shut down my computer in order to leave the site.

PEPSIMANTR commented 1 year ago

I also have the same bug on Chromium 115 since days.

erkinalp commented 1 year ago

Out of scope This repository covers the recommendation algorithm, not the client UI

AegonOfDragonstone commented 1 year ago

Works on my machine

Goldmaster commented 1 year ago

Looking into it!

RedshiftDrift commented 1 year ago

Same bug here https://X.com

Environment Firefox 115.0.2 on Windows 10.

thalx99 commented 1 year ago

Same bug here

FlipperPA commented 1 year ago

Tested, proven workaround: never visit that dumpster fire of a website again. Delete the app too.

Inderix commented 1 year ago

Can reproduce, on Firefox for Android and Firefox for Fedora Linux and OpenSUSE Tumbleweed.

RoootTheFox commented 1 year ago

can confirm for Firefox 115.0.2-1 on Arch Linux x86_64

d-bucur commented 1 year ago

Also I would like to add that the X logo in the top left is a different font from the official logo

turb commented 1 year ago

My two cents: maybe someone deployed by mistake the native X.org client app. Would definitely join xeyes and xsnow in the ultimate app package.

wallentx commented 1 year ago

𝕏 ohyou

MrBruz commented 1 year ago

Can confirm this issue occurs on both OpenBSD and Windows XP 😭

Undercoverdog commented 1 year ago

Works on my machine

Well, we are not handing your machine to all other users tho

april commented 1 year ago

I'm having the opposite problem of OP — for the last couple days, my Twitter tabs have had two close buttons. Is it possible that it's related to the same bug?

I've attached a screenshot it case it might be helpful to the developers.

image
ghost commented 1 year ago

having the same problem on chrome:

Screen Shot 2023-07-28 at 02 24 27
AtaxyaNetwork commented 1 year ago

If the :q!, as suggested by @abuseofnotation doesn't work, you can try the Emacs way: C-x C-c

Meaticus22 commented 1 year ago

If the :q!, as suggested by @abuseofnotation doesn't work, you can try the Emacs way: C-x C-c

Ewww eMacs

SleepyBrett commented 1 year ago

I see what the confusion might be. It's a delayed reaction, could take six months, could take a year or two. But this website will close.

leetfin commented 1 year ago

I think it's a latency issue. have you tried moving closer to the datacenter?

DJTOMATO commented 1 year ago

Why still not fixed, geez these programmers getting lazier everyday

src-ry commented 1 year ago

had to consult stackoverflow, but apparently you can type :qa to get out of it, however not well documented

lev-slinsen commented 1 year ago

Any news about this? I had to shut down my computer in order to leave the site.

Didn't work for me. After I turned it back on, the website opened again with the same problem.

UPD: Reinstalling the browser solved it.

UPD 2: Now I have to reinstall the browser every time to close twitter. I think I'll avoid visiting it until they fix this issue.

anvanza commented 1 year ago

This critical bug is still not resolved? Is this project dead?

RedstoneLP2 commented 1 year ago

can confirm for Firefox (latest), Opera (latest), Brave (latest), Chromium (latest) and BadWolf (latest) on Linux. can also confirm for Firefox (latest) and Chrome (latest) on android. if anyone wants to test lynx or other terminal browsers, be my guest

Chinmay-KB commented 1 year ago

Wake up babe, a new competitor to unable to exit vim memes just dropped

sai6855 commented 1 year ago

Elon: LTGM

xDEADC0DE commented 1 year ago

𝕏 ohyou

Now that’s a retro meme

ItMaga commented 1 year ago

Tweets in GitHub issues is new level

revskill10 commented 1 year ago
document.querySelector("X").on('click', chrome.closeCurrentTab())

Type in your console.

ejaz4 commented 1 year ago

Can confirm this is a problem. Does happen on Firefox 112 as well. I did some investigating and it looks like on some clients it redirects to the home screen and on others it goes right to the top depending on the platform.

I think we should consider this could be a problem with the Web Environment Integrity API not being implemented properly as it might think that the browser is not capable of closing the tab thus crashing and restarting the React app back to "/".

Twitter Devs should consider checking their setup of it here https://github.com/RupertBenWiser/Web-Environment-Integrity and make sure it's all setup properly. As the technology is new it might accidentally class the browser wrong so you should ideally be using navigator.* as a fallback.

meduzen commented 1 year ago

Environment Windows Chrome latest version, also Mac OS and iOS 14 Safari.

Please make sure you update your browser to the latest version, which is Safari XVI.

xtexChooser commented 1 year ago

lgtm, pls fix it

ho1ger commented 1 year ago

The problem spread to iOS. When I click on the "x" in the upper right corner of my device, a weird, twitter-like app opens!

image

luigiMinardi commented 1 year ago

Oh yeah... the TeX $\mathbb{X}$

emp3826 commented 1 year ago

same bug exists on Chrome115

wdbacker commented 1 year ago

This bug is spreading further, not only on browsers but now also on the android app. In addition, the "close button" moved to the center of the app header bar, making the UI experience even worse as users are more forced to close this app immediately.

ghost commented 1 year ago

Can confirm this is a problem. Does happen on Firefox 112 as well. I did some investigating and it looks like on some clients it redirects to the home screen and on others it goes right to the top depending on the platform.

I think we should consider this could be a problem with the Web Environment Integrity API not being implemented properly as it might think that the browser is not capable of closing the tab thus crashing and restarting the React app back to "/".

Twitter Devs should consider checking their setup of it here https://github.com/RupertBenWiser/Web-Environment-Integrity and make sure it's all setup properly. As the technology is new it might accidentally class the browser wrong so you should ideally be using navigator.* as a fallback.

https://github.com/Young-Lord/fight-for-the-open-web