Thumbs up looks like a turkey

[jglovier]

I cannot unsee that the thumbsup looks like a turkey.

If you are accepting pull requests, I will submit one.

[soffes]

Amazing.

[caniszczyk]

-_-

[jglovier]

So.... :+1: for pull request??

Here's what I came up with as an alternative. Happy to make adjustments based on feedback.

And at smaller scale:

[jimmybrancaccio]

That definitely looks way better :+1:

[reFX-Mike]

+1

[wp9015362]

@jglovier wrote:

Here's what I came up with as an alternative. Happy to make adjustments based on feedback.

I think your alternative looks better, but still not ideal.

Because:

If you look at some of the other Twemojis which involve a fist:

"White up pointing index" Twemoji:

"Victory hand" Twemoji:

"Raised fist" Twemoji:

then you can see that the lines between their fingers are white. And those white lines are thin.

Others, like the:

"Thumbs up sign" Twemoji:

"Thumbs down sign" Twemoji:

"Fisted hand sign" Twemoji:

have brown lines between their fingers and the lines are thick.

There are some more Twemojis which involve hands/skin where on some on of them thin white lines are being used in the design while on others thick brown lines are being used in the design.

I don't understand why there has to be this inconsistency. It looks, well, inconsistent and bad.

IMHO the Twemojis which are using the thin white lines look much better than the ones which are using the thick brown lines.

So, IMHO, the "thumbs up sign" Twemoji, the "thumbs down sign" Twemoji and the "fisted hand sign" Twemoji should have thin white lines between their fingers, instead of having thick brown lines.

So, any chance you could make it like that, so that the "thumbs up sign" Twemoji, the "thumbs down sign" Twemoji and the "fisted hand sign" Twemoji would be more consistent with the "white up pointing index" Twemoji, "victory hand" Twemoji, "raised fist" Twemoji and so on?

Regards

[jglovier]

@wp9015362 thanks for the awesome feedback!! You are so right re: inconsistent styles. I do like the idea of sticking with the white outline, although I'd love to hear from @caniszczyk or another maintainer before I go running too hard in any direction.

I know they commissioned the artwork for these from Icon Factory, and they were probably art directed externally from the open source efforts. From what I've seen the pull requests here have mostly been code related - not artwork - so I'd love if someone could confirm is this change is something the maintainers are even interested in?

[jglovier]

@wp9015362:

Where does GitHub take it from?

We use: https://github.com/github/gemoji

And why does GitHub use the Apple Emoji set and not the Twitter "Twemoji" Emoji set?

Primarily because the Twitter set was not a thing when we implemented Gemoji.

[jglovier]

@wp9015362 I don't maintain the Gemoji project, so you'd have to refer questions about that project to that repository.

[wp9015362]

@jglovier wrote:

although I'd love to hear from @caniszczyk or another maintainer before I go running too hard in any direction.

@caniszczyk :

Any update?

Regards

[dmitshur]

I've seen this issue reported independently (https://src.sourcegraph.com/sourcegraph/.tracker/248), so I just wanted to say :+1: to resolving this. I think improving the thumbsup, thumbsdown icons will help make twemoji even better. Thanks!

I agree with assessment done by @wp9015362. Using the thin, white line style sounds like a great plan!

[WebReflection]

V2 has landed with 1661 covered emoji VS just 874 in previous version.

Easy way to update? prefix /twemoji.min.js from MaxCDN via 2/twemoji.min.js and you're good to go.

P.S. it's probably still like a turkey, no designer ever read this repo

[reFX-Mike]

P.S. it's probably still like a turkey, no designer ever read this repo

Yeah, except @jglovier who even asked if it's OK to add the pull request for his much better version.

@WebReflection Please hand the maintenance over to someone else. Your heavy-handed, ignorant and almost insulting stewardship hurts this project more than anything.

We switched to Emoji One a while ago.

[WebReflection]

@reFX-Mike thanks for your kind words and you are welcome for the latest release.

As reminder, I take care only of the JS side of this project and I'd love to have some graphic designer responsible for this repository.

If I leave here, you'll have zero maintenance, js, design and assets included.

As second reminder, I'm volunteering here, I don't work at twitter since 2014, and I'm not willing to take insults for free.

Thanks for your understanding.

[reFX-Mike]

@WebReflection then stop volunteering here. You completely ignore people (like you ignored @jglovier ), then claim that nobody submitted anything (which is obviously wrong) and now pout when called out.

I've experienced your "help" first-hand, when I offered to fix the gray moons (something I could have done in note-pad, since SVG are very simple text-files) but you had to "make sure" we're all legit etc.

You. Are. Hurting. This. Project. More. Than. If. You. Stopped. Contributing. At. All.

[WebReflection]

you keep not understanding how this repository works. It's not in my will, nor power, to take assets/design/graphic decisions whatsoever.

I've explained it to you a while ago, and I'll keep pointing at this very same post from now on every time you'll keep ignoring this fact.

I'm not maintaining the assets part of this project, you are complaining with the wrong person and I won't tolerate any other personal insult to me in this project.

Take care.

[jglovier]

This thread is getting out of hand. I appreciate the passion for results, but @reFX-Mike being rude doesn't help open source. I'm certainly bummed to see the latest version not include a fix for this issue, and the lack of even a direct response. But I also appreciate the difficulty of maintaining a large open source project, and the work that @WebReflection is putting in. He should not be reprimanded for a problem which was not his to address.

To the maintainers of this project, I'd suggest locking the discussion on this thread to prevent further mis-expressed frustration or superflous +1 comments.

And thanks for all of your efforts on this project. :heart:

[jglovier]

Also, if the decision to not accept design changes via this repository is an intentional one, then it might be worth adding a wontfix label to this issue just for reference and clarification for future visitors.

[reFX-Mike]

@jglovier Just FYI: Andrea is not a "she" ;)

[WebReflection]

She should not be reprimanded for a problem which was not hers to address.

it's a he but Andrea is male name only in Italy, where I come from ... I'm kinda used to it, that's why people keep telling me I should put my face on my avatar.

I have to admit I like when people act differently mistaking my name, no matter if they support me or not :-) that shows sometimes why people still need to understand feminism. (not directed to you @jglovier, I'm sure you're a nice person regardless, it's just how it is online)

Thanks for your understanding. If you check the commit history of this project, all new assets landed in one shot and I have no contact at all with any designer at twitter.

All I can do is push for it like I've done already in order to obtain this current release.

Examples: https://github.com/twitter/twemoji/issues/116 https://github.com/twitter/twemoji/issues/103#issuecomment-173745303

Plus private messages with some contact I still have in there, unfortunately not a single designer.

Sad to find @reFX-Mike like "reward" for my effort ... but sure, I am hurting so much in here.

Cheers

[jglovier]

it's a he but Andrea is male name only in Italy, where I come from ... I'm kinda used to it, that's why people keep telling me I should put my face on my avatar.

@WebReflection whoops - very sorry about that. :grin:

[WebReflection]

no reason to be sorry, it's a common mistake.

Once a manager in a famous company shook my hand telling me: "welcome to this company, Ayako" and after that he shook her hand saying "and welcome to this company to you as well, Andrea"

Ayako is a very nice Japanese woman ... and assumptions based on foreigners names are fun :-)

About flagging as won't fix, I'll do that because I've closed it assuming since all new assets landed and no change was made, there was no bug to consider so, actually, it is a won't fix.

Again it's very difficult to have a statement from anyone about this repo assets.

Contributors list is made of developers with no, or kinda little, graphical skills.

Apologies but that's really not my fault, I was going to fork this and drop entirely the assets part ... I'm very happy we released version 2 today (actually everything arrived the 29th of February, can you believe it?)