twitter / twemoji

Emoji for everyone. https://twemoji.twitter.com/
MIT License
16.81k stars 1.85k forks source link

Incorrect sequence for "eye in speech bubble"? #405

Open joeattardi opened 4 years ago

joeattardi commented 4 years ago

I think the sequence for "eye in speech bubble" is incorrect.

According to the sequences used in the asset filenames, 1F441 200D 1F5E8 is being used. However, in https://unicode.org/Public/emoji/12.1/emoji-test.txt the fully qualified sequence is 1F441 FE0F 200D 1F5E8 FE0F. The sequence 1F441 200D 1F5E8 is an unqualified sequence.

Parsing the fully qualified sequence, 1F441 FE0F 200D 1F5E8 FE0F, results in two emoji images - an eye followed by a speech bubble.

I might be wrong here - I might be understanding the Emoji standard incorrectly, feel free to close this if that is the case.

jdecked commented 4 years ago

This is indeed a bug. According to the standard, we should appropriately handle fully-qualified emoji zwj sequences. Thanks for reporting.

nunoperalta commented 3 years ago

A user of one of my websites just reported this exact problem.

Male: 🤦‍♂️ 🤷‍♂️ Female : 🤦‍♀️ 🤷‍♀️

The above works well because the Emojis contain FE0F. Hex for 🤦‍♀️ : 20f09fa4a6e2808de29980efb88f20

However,

Male: 🤦‍♂ 🤷‍♂ Female: 🤦‍♀ 🤷‍♀

The above will show the Male/Female symbols besides each, because FE0F is missing. Hex for 🤦‍♀ : 20f09fa4a6e2808de2998020

Any estimated time for fixing this issue?

Livan-pro commented 1 year ago

@jdecked, so what is the status of this issue? This is still reproducible in 14.0.2.

jdecked commented 1 year ago

@Livan-pro no one working on Twemoji works at Twitter anymore – I assume you've seen the news around Elon Musk purchasing Twitter and the ensuing chaos. We had a fix sitting in our Phabricator draft diffs (drafts, not published, because it worked for public Twemoji but broke internal things), but that's gone now. 🙃 When will it be fixed? Your guess is now as good as mine.

joeattardi commented 1 year ago

@jdecked Sorry to hear you got caught up in that! In your opinion given the state of things now, should the Twemoji library be considered dead? With all this churn and chaos I'm wondering if it's worth continuing to support it in my library.

jdecked commented 1 year ago

@joeattardi I have no idea what Twitter plans to do with the official library, but we're (very slowly) setting up a fork over at https://github.com/jdecked/twemoji with some of the Twemoji designers. Understandably, it's slow going given we're currently job hunting, but we've started redesigning for Unicode 15 (we had them ready before all the chaos, but we can't use our designs from when we were at Twitter because that would get us in trouble) – that will be our first new major version on the fork. We're not exactly flush with free time, but we do care about keeping Twemoji alive as a project.

So, I can't make the decision for you, but hopefully the idea of supporting Twemoji in your library via the fork we've put together is adequately appealing.

joeattardi commented 1 year ago

@jdecked I will keep an eye on that repository, thank you! I'm definitely open to supporting the forked version once it is ready.

Wish you and your colleagues the best with the job search. I would be happy to offer help but I write code and am not so good at creating SVGs 😄