search

twitter / twemoji

Emoji for everyone. https://twemoji.twitter.com/
MIT License
16.79k stars 1.85k forks source link

fix: update portion of README still pointing to MaxCDN #585

Closed stefafafan closed 1 year ago

stefafafan commented 1 year ago

This pull request ( https://github.com/twitter/twemoji/pull/581 ) replaced links using MaxCDN to unpkg, but the first link in README was still pointing to MaxCDN. So I went ahead and replaced that portion too.

Related: https://github.com/twitter/twemoji/issues/580

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jd commented 1 year ago

This does not seem to solve the issue, as the base URL is still maxcdn.

stefafafan commented 1 year ago

I haven't really went through the code much, but this P-R is just an adjustment to the readme which was left behind from the following pull request https://github.com/twitter/twemoji/pull/581

rubber-bird commented 1 year ago

The script delivered on unpkg still contains https://twemoji.maxcdn.com/v/14.0.2/. Is there any chance to be fixed in near future ? 🐰

Screen Shot 2023-01-10 at 11 50 04 AM
WebReflection commented 1 year ago

somebody needs to push a new version but it's not clear who has rights to do so and until then, you can use the base property to fix your issues, as explained in the issue.