search

twitter / twemproxy

A fast, light-weight proxy for memcached and redis
Apache License 2.0
12.15k stars 2.06k forks source link

add Redis OBJECT command support #650

Closed steamboatid closed 3 years ago

steamboatid commented 3 years ago

Hi, as requested at issue #649, I try to add support to OBJECT command and couple of debian-based packaging files.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

TysonAndre commented 3 years ago

Debian support is completely unrelated to new redis command support and should not be part of the same PR.

Additionally, I don't have any experience with debian packaging and wouldn't be able to review this, anyway - The debian package maintainers who originally wrote these files could continue to do so without these being checked in.

Separately from that: Though I don't work for twitter, this repo still requires the CLA for contributions, and these files are authored by someone else - https://cla-assistant.io/twitter/twemproxy

Though how that could be fixed is irrelevant since I don't plan on including the changes made for debian packagers in this repo itself for the previously stated reasons.

  1. You represent that each of Your Contributions is Your original creation (see section 7 for submissions on behalf of others). You represent that Your Contribution submissions include complete details of any third-party license or other restriction (including, but not limited to, related patents and trademarks) of which you are personally aware and which are associated with any part of Your Contributions.

  2. Should You wish to submit work that is not Your original creation, You may submit it to Twitter separately from any Contribution, identifying the complete details of its source and of any license or other restriction (including, but not limited to, related patents, trademarks, and license agreements) of which you are personally aware, and conspicuously marking the work as "Not a Contribution. Third-party materials licensed pursuant to: [license name(s) here]" (substituting the bracketed text with the appropriate license name(s)).

I stated multiple times earlier in this review that I have no plans to add debian support to this repo.