search

twitter / twemproxy

A fast, light-weight proxy for memcached and redis
Apache License 2.0
12.15k stars 2.06k forks source link

Add monitor feature #653

Open kukey opened 3 years ago

kukey commented 3 years ago

implents #652

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kukey
:x: huangwei03

huangwei03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

kukey commented 3 years ago

@TysonAndre I suddenly realized the need to add a security authentication mechanism to prevent disclosure of request information caused by monitor command.

TysonAndre commented 3 years ago

I suddenly realized the need to add a security authentication mechanism to prevent disclosure of request information caused by monitor command.

Also, it would be reasonable to have it be off by default in the pool config (nc_conf) - if nobody's actively using it or deciding to enable it the performance impact would be surprising when someone tried monitor

kukey commented 3 years ago

@TysonAndre please review