Add systematic access to unicode properties

twitter / twitter-cldr-rb

Ruby implementation of the ICU (International Components for Unicode) that uses the Common Locale Data Repository to format dates, plurals, and more.

Apache License 2.0

672 stars 93 forks source link

Add systematic access to unicode properties #176

Closed camertron closed 8 years ago

camertron commented 8 years ago

Now that the groundwork has been laid (see #169, #171, #172, and #173), this PR can provide a systematic way to access, search for, and normalize property names and values. Pay special attention to the PropertiesDatabase class in this review.

This PR is part of a larger effort to refactor our Unicode properties support. See #170.

KL-7 commented 8 years ago

A few minor concerns, looks good otherwise :shipit:

coveralls commented 6 years ago

Coverage remained the same at ?% when pulling c0a08a350d976ff0b2d7dd0c4565c8e229abb275 on properties into 99aa86dca89cabb8ca8e21d0e1c0be437f2c3d19 on property_tries.