search

twitter / twitter-cldr-rb

Ruby implementation of the ICU (International Components for Unicode) that uses the Common Locale Data Repository to format dates, plurals, and more.
Apache License 2.0
672 stars 93 forks source link

Update to CLDR v32 and add locales [mk, es-ES] and update [es-419] #224

Closed bherila closed 5 years ago

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: alanbato
:white_check_mark: camertron
:x: Ben Herila

Ben Herila seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

camertron commented 5 years ago

Hey @bherila, thank you for this Herculean effort! Unfortunately I'm in the process right now of updating the library to CLDR v35.1, which is the most recent CLDR release. If things don't work out I'll take another look at this PR, but for now I'd like to shoot for the latest and greatest.

bherila commented 5 years ago

@camertron no worries, also seeing as the CLA has glitched and marked me with an X even though I've signed it. Do you think the update to v35 will happen relatively soon? Happy to wait and/or help you out if needed.

Side note, do you think you could include/update this list of locales as that'll prevent me from sending another PR and would be an absolutely HUGE help to me 😁

Thank you very much for the quick response!

camertron commented 5 years ago

@bherila please see my comments on https://github.com/twitter/twitter-cldr-rb/issues/225. Yes, I'm hoping to be able to release v35 support as soon as I can get all the tests to pass.

bherila commented 5 years ago

Sounds good, thanks again!!