search

twitter / twitter-cldr-rb

Ruby implementation of the ICU (International Components for Unicode) that uses the Common Locale Data Repository to format dates, plurals, and more.
Apache License 2.0
673 stars 93 forks source link

Add en-001 #231

Closed alex-stripe closed 4 years ago

alex-stripe commented 4 years ago

I followed the instructions in the readme.

The mri run (2.6.3) went smoothly, but the jruby run seemed to download cldr_v21, which was unexpected. So if that isn't right, this might need an update.

This is an important locale for us at Stripe because it allows us to serve english emails with currency formatters that don't assume you use $ as your currency symbol for USD (as a specific instance). It's the locale for the entire english speaking world.

Thanks! Let me know if there's something else I should run to make the jruby stuff have a different output.

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

SlexAxton commented 4 years ago

(Also, due to some weirdness i didn't diagnose in my laptop before sending this, I sent a fork from my personal account, slexaxton, as a PR from my work account, alex-stripe, but just wanted to note that I still control both accounts and all the commits were from a single user.)

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 95.092% when pulling 3aff35c6fca187c4ef4c6ca7aa444ceed703c251 on SlexAxton:en-001 into 8bfecbc8e4d20791ba1815b79c8ee64c732d4187 on twitter:master.

SlexAxton commented 4 years ago

And if it's helpful, this is for my employer ✨stripe ✨.

camertron commented 4 years ago

@SlexAxton nice, thank you!

The JRuby-based importers download CLDR v21 because unfortunately our collation implementation is based on it. I haven't had the time to dig into upgrading to later versions, which changed the format of the collation rules significantly.

camertron commented 4 years ago

Published as v5.4.0.

SlexAxton commented 4 years ago

ah, great. thanks for the speed and explanation! <3

SlexAxton commented 4 years ago

just as a note that i think en-001 didn't exist until cldr-v26 or so, so there won't be collation rules for it in v21. (english already kinda works by default everywhere, and you already have en-150 in the same state)

Not a huge worry or anything, but figured I'd mention it.

camertron commented 4 years ago

Ah ok that makes sense :)