twitter / twitter-server

Twitter-Server defines a template from which services at Twitter are built

http://twitter.github.io/twitter-server/

Apache License 2.0

1.57k stars 264 forks source link

fix sbt deprecated warnings #52

Closed matsu-chara closed 7 years ago

matsu-chara commented 7 years ago

Summary: Problem

Some sbt operators are deprecated

Solution

fix warnings.

Result

no warn (without Build trait deprecation)

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@ba6cdda). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #52   +/-   ##
==========================================
  Coverage           ?   65.84%           
==========================================
  Files              ?       65           
  Lines              ?     1745           
  Branches           ?       61           
==========================================
  Hits               ?     1149           
  Misses             ?      596           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba6cdda...4831bc3. Read the comment docs.

mosesn commented 7 years ago

@matsu-chara I made a breaking API change to twitter commons, which makes it difficult for us to build twitter-server & friends. I'm planning on removing the dependency on twitter commons (which is why I made the change!) but in the mean time, we can't safely publish without risking breaking the build, so I'm going to publishing this in for a few days until we remove the dependency completely. Sorry for the delay! In the mean time, I'll try to merge it in internally so it will be good to go when we turn publishing to github back on.

mosesn commented 7 years ago

@matsu-chara this was merged internally, but we can't publish it to github yet. I'll let you know when it's published!

mosesn commented 7 years ago

@matsu-chara this finally made it to github, thanks! https://github.com/twitter/twitter-server/commit/9551a461877dfa381add7d6d10db5ae81d67ad27