twitter / twitter-server

Twitter-Server defines a template from which services at Twitter are built

http://twitter.github.io/twitter-server/

Apache License 2.0

1.57k stars 264 forks source link

Migrate to build sbt #53

Closed matsu-chara closed 7 years ago

matsu-chara commented 7 years ago

Problem:

Build trait was deprecated

Solution:

step1: move project/Build.scala to build.sbt step2.1: remove Build trait step2.2: remove unnecessary import(sbt, Keys, and some plugins) step3: remove unnecessary settings Defaults.coreDefaultSettings which is loaded by CorePlugin JmhPlugin.projectSettings which is loaded by JmhPlugin Result: Migration is completed

codecov-io commented 7 years ago

Codecov Report

Merging #53 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    67.42%   67.42%           
========================================
  Files           65       65           
  Lines         1836     1836           
  Branches        65       82   +17     
========================================
  Hits          1238     1238           
  Misses         598      598

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31c7219...f0e5766. Read the comment docs.

ryanoneill commented 7 years ago

Hi @matsu-chara, thank you very much for the pull request. I'm going to attempt to pull it in and get it merged internally. When it is merged, shortly thereafter it will be pushed back to GitHub on the 'develop' branch.

ryanoneill commented 7 years ago

Hi @matsu-chara. Thanks for the contribution. This was pushed back out to GitHub on the develop branch as https://github.com/twitter/twitter-server/commit/46ac5d184f74d08d175fb13761723fbbb7f7f882