twitter / twitter-server

Twitter-Server defines a template from which services at Twitter are built

http://twitter.github.io/twitter-server/

Apache License 2.0

1.57k stars 264 forks source link

Drop dependency on finagle zipkin-core #56

Closed gpoulin closed 6 years ago

gpoulin commented 6 years ago

TwitterServer doesn't contains any code depending on it anymore. It shouldn't affect the runtime since the actual ScribeZipkinTracer is in finagle zipkin and not zipkin-core

CLAassistant commented 6 years ago

All committers have signed the CLA.

codecov-io commented 6 years ago

Codecov Report

Merging #56 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #56   +/-   ##
========================================
  Coverage    67.95%   67.95%           
========================================
  Files           62       62           
  Lines         1629     1629           
  Branches       110      100   -10     
========================================
  Hits          1107     1107           
  Misses         522      522

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 479babc...fb20aca. Read the comment docs.

ryanoneill commented 6 years ago

Hi @gpoulin, thanks for the pull request. This looks to be correct. I will work on pulling it into our internal codebase with attribution to you. It will then get pushed back out to GitHub.

ryanoneill commented 6 years ago

Hi @gpoulin. Thanks again for the contribution to Twitter Server. This has been submitted internally and pushed back out to GitHub as https://github.com/twitter/twitter-server/commit/9f5b885852e1afee978af55ce3aa74231d27a8f7