search

twitter / twitter-text

Twitter Text Libraries. This code is used at Twitter to tokenize and parse text to meet the expectations for what can be used on the platform.
https://developer.twitter.com/en/docs/counting-characters
Apache License 2.0
3.08k stars 522 forks source link

5 TLDs missing on tld_lib.yml #261

Closed wstaub closed 6 years ago

wstaub commented 6 years ago

The following 5 TLDs are missing from https://github.com/twitter/twitter-text/blob/master/conformance/tld_lib.yml

Domain Type TLD Manager
.charity generic Corn Lake, LLC (Donuts)
.inc generic Intercap Holdings Inc.
.llc generic Afilias plc
.sport generic Global Association of International Sports Federations (GAISF)
.招聘 generic Dot Trademark TLD Holding Company Limited

As the library seems to be used for Twitter, domains like gymnastics.sport are not recognized there.

Please update the TLD listing listing as quickly as possible or automate the update by drawing the content from the DNS root zone or from https://www.iana.org/domains/root/db

Regards,

Werner Staub

dlamacchia commented 6 years ago

Thanks for this report. These new TLDs will be added to the next version (code is merged to our local repo). I'm going to leave this ticket open until the next package is formally released.