search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.68k stars 580 forks source link

Move MonitorTest from WordSpec to FunSuite #271

Closed muachilin closed 4 years ago

muachilin commented 4 years ago

Problem

In CONTRIBUTING.md, it is mentioned that scala tests should use FunSuite instead of WordSpec. However, originally, the MonitorTest used WordSpec.

Solution

Modify the tests in MonitorTest from WordSpec into FunSuite.

Result

MonitorTest fulfills the testing format FunSuite, mentioned in CONTRIBUTING.md.

ryanoneill commented 4 years ago

Hi @muachilin, this commit was pushed back out to GitHub as https://github.com/twitter/util/commit/83145aae07485ff2b9dfbebd231f5cf90ea7fd82 Thanks again for the contribution!

muachilin commented 4 years ago

Thank you!