search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.69k stars 581 forks source link

Support HP NonStop. Closes #272 #273

Closed pvasterd closed 4 years ago

pvasterd commented 4 years ago

Problem

When creating an com.twitter.jmv.Hotspot object on HotSpot JVMs that do not implement JVM metrics, such as the HP NONSTOP JVM, the creation fails with a javax.naming.OperationNotSupportedException.

Solution

As these metrics/counters are not mandatory, creation of the com.twitter.jmv.Hotspot should just continue with a WARN message that these counters are not available.

Result

Support for more Hotspot JVMs, such as HP NONSTOP JVM.

See #272

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

mosesn commented 4 years ago

Oh, would you also mind following our CONTRIBUTING.md guidelines? Please update your description and commit message per:

https://github.com/twitter/util/blob/develop/CONTRIBUTING.md#pull-requests

pvasterd commented 4 years ago

Oh, would you also mind following our CONTRIBUTING.md guidelines? Please update your description and commit message per:

https://github.com/twitter/util/blob/develop/CONTRIBUTING.md#pull-requests

Done!

pvasterd commented 4 years ago

@mosesn , would be wonderful if this PR could make the 20.4.0 release. Is there anything you still want me to do?

pvasterd commented 4 years ago

Oh, would you also mind following our CONTRIBUTING.md guidelines? Please update your description and commit message per:

https://github.com/twitter/util/blob/develop/CONTRIBUTING.md#pull-requests

Yes, I think I followed the guidelines just now.

pvasterd commented 4 years ago

Closing this PR as the contents of the pull request already part of 20.4.0. Thanks team Twitter for picking this up!