search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.68k stars 580 forks source link

Update sbt to 1.5.2 #288

Closed felixbr closed 3 years ago

felixbr commented 3 years ago

Problem

sbt supports Scala 3 natively in the recent versions (e.g. 1.5.x) and I want the build to be ready for Scala 3.

Solution

Updating sbt from 1.3.10 to 1.5.2

Result

sbt is updated to 1.5.2 and most warnings addressed (i.e. auto-reloading, unused settings, and migration to slash-syntax for settings)

As usual, I cannot tell if this clashes with any Twitter-internal things, so please tell me if it does.

mosesn commented 3 years ago

@felixbr thanks for the PR! Sorry for the delay in getting back to you. I don't think this clashes with anything, let me double check.

mosesn commented 3 years ago

Sorry for the delay, I've run into a bunch of sbt weirdness. New sbt versions apparently rearrange the classpath. I'm hoping to have it sorted today or tomorrow, @eed3si9n has been tremendously helpful!

mosesn commented 3 years ago

Thanks for your patience, this was merged in! https://github.com/twitter/util/commit/659e818caf3ce173466c68d50e4382e1b2ef9892