search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.68k stars 580 forks source link

Match Scala version for 2.13.6 in CI #292

Closed felixbr closed 3 years ago

felixbr commented 3 years ago

When I opened the PR to update Scala to 2.13.6 I forgot to update the version for Github Actions. This PR fixes that.

As a side-note: Have you considered using sbt-github-actions? It's pretty good in keeping these things consistent and many projects use it successfully.

Cheers ~ Felix

codecov-commenter commented 3 years ago

Codecov Report

Merging #292 (8e7337e) into develop (8e964d9) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 8e7337e differs from pull request most recent head 7cd2f9e. Consider uploading reports for the commit 7cd2f9e to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
- Coverage    51.78%   51.76%   -0.02%     
===========================================
  Files          311      311              
  Lines        16769    16769              
  Branches       985     1002      +17     
===========================================
- Hits          8684     8681       -3     
- Misses        8085     8088       +3
Impacted Files Coverage Δ
.../main/scala/com/twitter/util/reflect/Classes.scala 83.33% <0.00%> (-16.67%) :arrow_down:
...core/src/main/scala/com/twitter/util/Promise.scala 77.55% <0.00%> (-0.82%) :arrow_down:
...ore/src/main/scala/com/twitter/util/Duration.scala 84.74% <0.00%> (-0.57%) :arrow_down:
util-core/src/main/scala/com/twitter/io/Buf.scala 93.27% <0.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e964d9...7cd2f9e. Read the comment docs.

cacoco commented 3 years ago

@felixbr FWIW, we have looked at sbt-github-actions and well, we have 5 repositories (twitter/util, twitter/scrooge, twitter/finagle, twitter/twitter-server and twitter/finatra) that are developed internally in a monorepo and which we try to keep in sync with each other once in GitHub and that makes off the shelf tools like this a bit challenging to integrate. Thanks for the suggestion. We will probably circle back to it and take another look in the future.

roanta commented 3 years ago

Thanks @felixbr, this landed in https://github.com/twitter/util/commit/465601a701d3f604f73e3efcb194bc448efcf492