search

twitter / util

Wonderful reusable code from Twitter
https://twitter.github.io/util
Apache License 2.0
2.69k stars 581 forks source link

Update scala versions #304

Closed felixbr closed 2 years ago

felixbr commented 2 years ago

This is primarily to get away from the release candidate version of Scala 3. I also updated the other Scala versions for general maintenance.

edit: I missed PR #300 which already updates Scala 3 to a non-RC version, my apologies. I'll let you be the judge which PR to accept and will modify/rebase/close mine accordingly.

edit2: I wanted to add CI for Scala 3 as well but scoverage isn't quite there yet and some build adjustments are needed, so this will require a separate PR.

Cheers ~ Felix

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 2 years ago

Codecov Report

Merging #304 (afcbd9a) into develop (9f15cce) will increase coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    49.29%   49.31%   +0.02%     
===========================================
  Files          322      322              
  Lines        18523    18523              
  Branches      1055     1108      +53     
===========================================
+ Hits          9131     9135       +4     
+ Misses        9392     9388       -4
Impacted Files Coverage Δ
util-core/src/main/scala/com/twitter/io/Buf.scala 93.27% <0.00%> (ø)
...core/src/main/scala/com/twitter/util/Promise.scala 79.84% <0.00%> (+0.38%) :arrow_up:
...ore/src/main/scala/com/twitter/util/Duration.scala 85.39% <0.00%> (+0.56%) :arrow_up:
...in/scala/com/twitter/logging/QueueingHandler.scala 100.00% <0.00%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f15cce...afcbd9a. Read the comment docs.

felixbr commented 2 years ago

The failing test seems to be the same flaky one as in the past

felixbr commented 2 years ago

The last commit is a bit off-topic but hopefully it fixes the flaky test which has been bugging me for a while now.

felixbr commented 2 years ago

Almost everything I'm trying to do here has landed in develop via other commits, so I'm closing this PR and will rebase #305 and #306 onto develop when I have time to do so.