See what happens

[codecov-commenter]

Codecov Report

Merging #307 (34b8db8) into develop (936ceec) will increase coverage by 0.18%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
+ Coverage    49.11%   49.30%   +0.18%     
===========================================
  Files          320      322       +2     
  Lines        18459    18532      +73     
  Branches      1074     1062      -12     
===========================================
+ Hits          9067     9138      +71     
- Misses        9392     9394       +2     

Impacted Files	Coverage Δ
util-core/src/main/scala/com/twitter/io/Buf.scala	93.09% <0.00%> (ø)
...core/src/main/scala/com/twitter/util/Promise.scala	79.45% <0.00%> (ø)
.../scala-2.13+/com/twitter/conversions/SeqUtil.scala	100.00% <0.00%> (ø)
...in/scala-2.13+/com/twitter/util/HealthyQueue.scala	68.42% <0.00%> (ø)
...ore/src/main/scala/com/twitter/util/Duration.scala	85.39% <0.00%> (+0.56%)	:arrow_up:
...rk/src/main/scala/com/twitter/jvm/CpuProfile.scala	70.88% <0.00%> (+70.88%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 936ceec...34b8db8. Read the comment docs.

[felixbr]

Hi,

I noticed you're hitting similar trouble with sbt-scoverage as I have recently. Maybe it would be helpful to run coverage only for the main Scala version (i.e. 2.13.6 currently) instead of all versions.

The code and tests are the same either way, so imo it would be sufficient to only do it for the main version and it might make the sbt-scoverage version stuff easier.

You can take a look at #308 as an example where I've excluded coverage for Scala 3 and it seems to work nicely.

Cheers ~ Felix

edit: There is also a coverageEnabled setting in sbt, which might be helpful but I didn't have too much luck with it, so I added conditionals in the CI-build instead.

[bryce-anderson]

Looks like it worked.