twitter / vireo

Vireo is a lightweight and versatile video processing library written in C++11
MIT License
932 stars 111 forks source link

compile error #10

Open jojo05 opened 6 years ago

jojo05 commented 6 years ago

CXX internal/decode/libvireo_la-aac.lo internal/decode/aac.cpp:26:10: fatal error: libavformat/avformat.h: No such file or directory

include "libavformat/avformat.h"

      ^~~~~~~~~~~~~~~~~~~~~~~~
jojo05 commented 6 years ago

This is the error with ./configure --enable-gpl

CXX internal/decode/libvireo_la-h264.lo internal/decode/h264.cpp:27:10: fatal error: libavformat/avformat.h: No such file or directory

include "libavformat/avformat.h"

canbal commented 6 years ago

Strangely AAC decoder is importing libavformat header. That feels like a typo to me. Can you see if can safely remove first 3 lines

extern "C" {
#include "libavformat/avformat.h"
}

from internal/decode/aac.cpp?

Please also attach your full log for more context.

jojo05 commented 6 years ago

I am building on a clean fedora 27 system with gcc 7.2.1 I removed the 3 lines from internal/decode/aac.cpp and encode/aac.cpp and it compiles but I get a linker error later on log.txt

canbal commented 6 years ago

Thanks for confirming, merged the change: https://github.com/twitter/vireo/pull/14

The linker errors you're seeing are unrelated to the original issue and known. I suspect it's related to the gcc version. Will keep this thread posted about the resolution.