search

twitter / vireo

Vireo is a lightweight and versatile video processing library written in C++11
MIT License
927 stars 111 forks source link

'vireo/config.h' file not found #12

Closed giulianoc closed 6 years ago

giulianoc commented 6 years ago

Hi, I was testing helloworld.cpp outside of the video directory and I got the following error:

/Users/multi/GestioneProgetti/Development/vireo/vireoBinaries/include/vireo/dependency.hpp:28:10: fatal error: 'vireo/config.h' file not found

include "vireo/config.h"

I guess, since 'vireo/config.h' is included from 'vireo/dependency.hpp', I guess 'vireo/config.h' has to be installed during the 'make install' command.

Do you agree?

To solve this issue I copied manually config.h into the vireo installation directory.

Best regards Giuliano

canbal commented 6 years ago

Thanks for pointing this out. Yes, this indeed is a bug. This shoudl fix it for you. https://github.com/twitter/vireo/compare/config?expand=1

Can you check and confirm?

canbal commented 6 years ago

fixed in https://github.com/twitter/vireo/pull/15