search

twittwer / nx-tools

Workspace for Nx Plugins.
40 stars 7 forks source link

compdoc nx plugin: support nx per-project configuration #46

Closed christianacca closed 2 years ago

christianacca commented 3 years ago

Seems like compdoc nx plugin does not work with a repo that uses per-project configuration

➜  static-web-apps-auth git:(master) npm run nx -- add @twittwer/compodoc                      

> swa-auth@0.0.0 nx /Users/christian.crowhurst/Documents/git/static-web-apps-auth
> nx "add" "@twittwer/compodoc"

Unable to read workspace file '/Users/christian.crowhurst/Documents/git/static-web-apps-auth/angular.json': Invalid format version detected - Expected:[ 1 ] Found: [ 2 ]
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! swa-auth@0.0.0 nx: `nx "add" "@twittwer/compodoc"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the swa-auth@0.0.0 nx script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/christian.crowhurst/.npm/_logs/2021-08-19T08_44_46_644Z-debug.log

Tried installing the dev deps manually and then run the schematic, but that doesn't add the necessary script entries to the project.json

twittwer commented 3 years ago

Yes, it is currently not supported - might require some refactorings to handle this setup.

the-ult commented 3 years ago

Would be great if this plugin would support the per-project configuration, since it is gonna be the default wilt NX 13. (probably november)

Is it atm possible to get the plugin working with workspace.json and the per-project-configuration? Like, what should we configure manually?

twittwer commented 3 years ago

I'm working on a rewrite based on the nrwl's devkit to ensure compatibility with all the workspace setups. ATM it should work with angular.json & workspace.json but not with per-project-configuration.

christianacca commented 3 years ago

Cool. Thanks for effort

On Wed, 6 Oct 2021, 17:02 Tobias Wittwer, @.***> wrote:

I'm working on a rewrite based on the nrwl's devkit to ensure compatibility with all the workspace setups. ATM it should work with angular.json & workspace.json but not with per-project-configuration.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/twittwer/nx-tools/issues/46#issuecomment-936567323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGYOPRJPIRNT45BN34NRILUFRXLFANCNFSM5CNXSCSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

the-ult commented 3 years ago

Thanks for the effort @twittwer

In the meantime, is it possible to accomplish this manually atm? Like, what should we adjust in our configs?

twittwer commented 2 years ago

I'm sorry for the long response time 🙈 But now the latest version (>=1.6.0) supports standalone project configurations 🎉

christianacca commented 2 years ago

Thanks :-)

On Sun, Oct 31, 2021 at 10:55 PM Tobias Wittwer @.***> wrote:

I'm sorry for the long response time 🙈 But now the latest version (>=1.6.0) supports standalone project configurations 🎉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/twittwer/nx-tools/issues/46#issuecomment-955806548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGYOPXXG4UCG7TMFGT6ZHDUJXCPRANCNFSM5CNXSCSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.