twittwer / nx-tools

Workspace for Nx Plugins.
40 stars 7 forks source link

fix(compodoc): correct `coverageTest` behavior #84

Closed HugoMendes98 closed 8 months ago

HugoMendes98 commented 9 months ago

Hello @twittwer,

There was a misunderstanding in the previous implementation: The coverageTest flag runs a "coverage test" and do not generate the documentation. The disableCoverage removes the Documentation coverage page in the documentation (image).

I'm also reversing the order of the flags, before https://github.com/twittwer/nx-tools/pull/83, as the two flags don't have the same (exact) category.

image

twittwer commented 9 months ago

What do you mean by

The coverageTest flag runs a "coverage test

Is the coverage only calculated if thecoverageTest is set to a value above 0?

HugoMendes98 commented 9 months ago

The comment coverage is always calculated, unless the disableCoverage flag is set.

Visible in the Documentation coverage page image

The coverageTest option (when > 0) turns the command into a test:

I personally use it in CIs to ensure that the code is sufficiently commented.

I have not tested it, but the coverageMinimumPerFile flag may have the same behavior.

Have I made it clearer?

HugoMendes98 commented 9 months ago

Hello @twittwer,

Any news on this?

twittwer commented 9 months ago

Except for the confusion about the description it looks clearer to me.

When you can clarify this one point, I'll try to release it during the weekend.