search

twlevelup / watch_edition_react

A smartwatch simulator, built in ReactJS
MIT License
3 stars 2 forks source link

Coveralls spike #17

Closed sinan-aumarah closed 7 years ago

sinan-aumarah commented 7 years ago

is it worth adding?

have a look at the report https://coveralls.io/github/twlevelup/watch_edition_react

ohh and it also gives as an svg icon with the coverage percentage

watsonarw commented 7 years ago

As long as this is an auxiliary tool, and we can still get code coverage reports and fail the build below covfefe thresholds without this, then I'm OK with it. In my experience, students won't go out of their way to check test coverage, and will only notice that it's a thing when the build fails because of it (and even then it sometimes has to be pointed out).

sinan-aumarah commented 7 years ago

@watsonarw I was just really trying to test it. I think it's too gimmicky and not really worth adding extra complexity just for the SVG coverage percentage. Jest's coverage report provides the same details if not better. I will remove this branch soon.