Run in docker - Githubissues

twlevelup / watch_edition_react

A smartwatch simulator, built in ReactJS

MIT License

3 stars 2 forks source link

Run in docker #25

Closed watsonarw closed 7 years ago

watsonarw commented 7 years ago

Fix package-lock
Convert ./go to use docker
Rename old ./go to ./go-node as a fallback.
Use generic .node-version file instead of .nvmrc for docker, .nvmrc is now a symlink.

watsonarw commented 7 years ago

I'd like to test this across a range of machines before merging it. We should capture/update the setup instructions for each OS over at https://github.com/twlevelup/watch_edition_react/wiki/Setup

[x] Mac
[ ] Windows 10
[ ] Windows < 10
[ ] Ubuntu

raytung commented 7 years ago

Should we support Windows < 10? As far as I know, Docker runs on a virtual machine for < win10

raytung commented 7 years ago

We can probably automate the installation of Docker if we have a list of supported OS.

watsonarw commented 7 years ago

Good question about Windows < 10, you're correct, docker toolbox is required for Windows < 10 because it has no Hyper-V. That's why I listed it separately, but if we don't want to support it, then even better. I was trying to think of possible OS's that participants would be using.

watsonarw commented 7 years ago

Tested working on Mac. I'll try on an actual Windows 10 machine tonight. The windows 10 VM in Virtualbox didn't support hyper-v...