twlevelup / watch_edition_react

A smartwatch simulator, built in ReactJS
MIT License
3 stars 2 forks source link

Add extra button type to override button functions without changing them #26

Closed alex-mitchem closed 7 years ago

alex-mitchem commented 7 years ago

Basically a way to short circuit the button onclick functions. Implemented to allow the notification popup to close on pressing a button without screwing up the existing button functions. Theres an issue where submitting multiple notifications without changing the text stop the popup from appearing (due to the props not actually changing, meaning an update isn't triggered), but I'd like opinions on the implementation before trying to fix it.