search

twlite / discord-ytdl-core

Simple ytdl wrapper for discord bots with custom ffmpeg args support.
https://www.npmjs.com/package/discord-ytdl-core
Apache License 2.0
51 stars 10 forks source link

feat(Typings): Exporting Interfaces #30

Closed EhsanFox closed 2 years ago

EhsanFox commented 2 years ago

Exporting interfaces since the package 2nd param have a different interface from "ytdl-core", so the other TS Users/package would have more access.

EhsanFox commented 2 years ago

Fixed examples in the readme too!

EhsanFox commented 2 years ago

@DevAndromeda, Sorry but i have to ping you, since there is no reviewers or Assigned person to PR's

EhsanFox commented 2 years ago

fixed the version number for publishing the package for the PR merge, and also changed the test command from "cd test && node test.js" to "node test/test.js" since the cd command is not available in Windows platform

twlite commented 2 years ago

fixed the version number for publishing the package for the PR merge, and also changed the test command from "cd test && node test.js" to "node test/test.js" since the cd command is not available in Windows platform

cd is available on windows. Also this test script is not public so it isnt useful to anybody else

EhsanFox commented 2 years ago

as I said, I would love to see and use this feature as soon as I can, so I would be able to finish a project that I'm working on.