pkg/kgo: use codecType explicitly

twmb / franz-go

franz-go contains a feature complete, pure Go library for interacting with Kafka from 0.8.0 through 3.7+. Producing, consuming, transacting, administrating, etc.

BSD 3-Clause "New" or "Revised" License

1.78k stars 182 forks source link

pkg/kgo: use codecType explicitly #697

Closed cristaloleg closed 4 months ago

cristaloleg commented 6 months ago

Scrolling through code I found mysterious constants, looks like this should be codecType.

However, codec param is byte but codecType is uint8 I don't think it's a problem. Changing function param will increase diff for no big reason.

Thanks for the franz-go BTW ;)

twmb commented 4 months ago

Sorry for the delay, the last few months were much busier than anticipated. Releasing imminently!