search

twmb / franz-go

franz-go contains a feature complete, pure Go library for interacting with Kafka from 0.8.0 through 3.7+. Producing, consuming, transacting, administrating, etc.
BSD 3-Clause "New" or "Revised" License
1.78k stars 182 forks source link

Don't set nil config when seeding topics in kfake cluster #826

Open colega opened 2 weeks ago

colega commented 2 weeks ago

Setting the configs to nil causes it to panic later when trying to alter the topic configs, as it only checks for entry in the map not being present, not for it not being nil.

colega commented 2 weeks ago

I don't see any tests here, I'd be happy to add one, but then I'd have to import kgo and kadm from kfake, is that ok?