search

twmb / kcl

Your one stop shop to do anything with Kafka. Producing, consuming, transacting, administrating; 0.8.0 through 3.2+
BSD 3-Clause "New" or "Revised" License
194 stars 19 forks source link

bump protoreflect to v1.15.3 #34

Closed celrenheit closed 10 months ago

celrenheit commented 1 year ago

Fixes a panic when consuming protobuf formatted messages

celrenheit commented 10 months ago

Can we merge this ?

twmb commented 10 months ago

Yes, very good reminder. I've been neglecting this repo (truly, not much has changed API wise that's worth adding in the 2yr+ since I wrote the original codebase). Originally when you created this PR, I was waiting for v1.15 to be released in franz-go, to bump it here correspondingly and release kcl. That came and went and I forgot about this PR / repo. I do intend to release franz-go again, v1.16, sooner than later this month, and will release kcl at the same time (including this PR first, and then a go get -u ./... globally again). Sorry for the delay.

celrenheit commented 10 months ago

No worries, I've just on-boarded someone who needed a kafka client. Recommended this one and realized that I was not yet merged. We then did a local build from my branch and everything works correctly now. No rush