search

twmht / python-rocksdb

Python bindings for RocksDB
BSD 3-Clause "New" or "Revised" License
274 stars 89 forks source link

OSX support for building, simple update in setup.py #20

Closed metachris closed 6 years ago

metachris commented 6 years ago

Added extra_compile_args to build on OSX by default.

metachris commented 6 years ago

Would be much appreciated if you could take a quick look, and if you like it to create a new release on PyPI. We'd like to use this package in neo-python, but need to have a working installation from PyPI when running OSX. This PR should fix it, and is very simple ;)

twmht commented 6 years ago

@metachris

thanks! I will do a quick review.

metachris commented 6 years ago

Great. Can you give me a quick idea about when you plan to do the next release? Would be great to be able to install python-rocksdb from PyPI on OSX without hacks ;)

twmht commented 6 years ago

now python-rocksdb is upgraded to 0.6.8.

thanks for your contribution!

metachris commented 6 years ago

my pleasure! 👍