Sequence Number methods marked TODO

twmht / python-rocksdb

Python bindings for RocksDB

BSD 3-Clause "New" or "Revised" License

276 stars 90 forks source link

Sequence Number methods marked TODO #32

Open HaraldGustafsson opened 6 years ago

HaraldGustafsson commented 6 years ago

Hi,

I'm wondering for the reason of the following methods are TODO, any specific issue that you found with making the python bindings? I'm wondering since my project would benefit from having at least the GetLastSequenceNumber method, and if not too much of an problem I could add it.

    # TODO: SequenceNumber GetLatestSequenceNumber()
    # TODO: Status GetUpdatesSince(
              # SequenceNumber seq_number,
              # unique_ptr[TransactionLogIterator]*)

twmht commented 6 years ago

@HaraldGustafsson

I think it's not related to any specific issue, just need some time to implement.

it's also welcome to any PR.

thank you!