twmr / gerrit.el

gerrit integration in emacs
44 stars 5 forks source link

Switch from global to per-project configuration #13

Closed f279801 closed 11 months ago

f279801 commented 3 years ago

Thank you a lots for your nice package. Just need to adapt it a bit to my flow and guess that you may interest on it as well in case it can be useful for other guys.

twmr commented 3 years ago

@f279801 Thanks a lot for your contribution!

It seems as if you are using multiple gerrit servers and want to make the gerrit hostname dependent on the current name of the git repository (via magit-toplevel). Have you thought about using the infrastructure provided by the upstream project.el package or by using per directory local variables (.dir-locals.el)?

Furthermore, why is the project name returned by gerrit-get-current-project not sufficient for you? Isn't the project-name included in .git/config? If it is included, could it be that @snogge's PR

14 fixes the issue that you have with this function?