Allow HTTP/HTTPS to be toggled

twmr / gerrit.el

gerrit integration in emacs

44 stars 5 forks source link

Allow HTTP/HTTPS to be toggled #30

Closed elken closed 2 years ago

elken commented 2 years ago

Allows instances that don't have HTTPS configured to work. Defaults to HTTPS as expected, but my work one doesn't support HTTPS.

elken commented 2 years ago

On second thought, maybe it would be preferable to just let the user specify the protocol directly, so RFC

twmr commented 2 years ago

@elken Thx for your contribution! For the me code looks good, but I just wanted to know how this can be configured in other projects like e.g. in ghub.el. There it is possible to configure a list of hosts that are "insecure", for which "http://" is used as the protocol.

(defvar ghub-insecure-hosts nil
  "List of hosts that use http instead of https.")

I would therefore keep your current implementation.

elken commented 2 years ago

Makes sense, no worries :)