search

twmr / pytest-sphinx

sphinx doctest plugin for pytest
BSD 3-Clause "New" or "Revised" License
29 stars 6 forks source link

Remove `_importconftest` call on pytest>=8 #58

Closed bluetech closed 10 months ago

bluetech commented 10 months ago

The plugin has some code which accesses some pytest internals to import conftests:

https://github.com/thisch/pytest-sphinx/blob/28f8f4ddf83615da43c138a2360b5246b9fe55b2/src/pytest_sphinx.py#L558-L563

Similar code was present in pytest's builtin doctest plugin, but I've removed it just now: https://github.com/pytest-dev/pytest/pull/11808

The code is no longer necessary on pytest>=8.0.0rc1 (possibly even before, but I'm not sure about that). It'd be great if pytest-sphinx remove it as well, so that it doesn't break if/when pytest breaks these internals.

twmr commented 10 months ago

Thx for the info @bluetech. I've just removed it.

gauteh commented 8 months ago

Also encountered this. Thanks for the fix. Anxiously awaiting the next release :D

@knutfrode