search

twnlink / LinuxED

LinuxED is an installer for EnhancedDiscord specifically made for Linux and MacOS.
MIT License
21 stars 7 forks source link

Follow XDG Base Directory Specification #3

Closed Freso closed 5 years ago

Freso commented 5 years ago

Place EnhancedDiscord files under $XDG_DATA_HOME as specified by the XDG Base Directory Specification version 0.7.

This allows LinuxED to be run from anywhere while still having its data files located in a single location and also means for users that there’s one fewer location where data files will be scattered around their file system.

Fixes https://github.com/Cr3atable/LinuxED/issues/2

twnlink commented 5 years ago

I'd prefer for this to be optional. There's also a merge conflict with the latest commit. I will merge once these two issues are fixed.

twnlink commented 5 years ago

This PR is now merged however I would like to comment on how the new update works. Rather than defaulting to the XDG Base Directory, the installer now provides the option to use it upon starting as shown in the following screenshot: Example of option

If you use this option the installer will then automatically use the XDG Base Directory. If there is an EnhancedDiscord installation within the XDG Base Directory on start, the installer will default to the XDG Base directory. This allows users to optionally pick what directory they want to install EnhancedDiscord in and makes sure not to be too much of a hassle if you choose anything besides the default.

Thank you for your pull request and issue.

Freso commented 5 years ago

Thanks. :) I don’t agree with not making the XDG standard approach the default, but I’m not gonna bother you more about that now that it is at least an option. ;)