search

two-brothers / overcooked-cms

0 stars 0 forks source link

Separate data and presentation components #13

Closed nikeshnazareth closed 5 years ago

nikeshnazareth commented 5 years ago

The components currently use FlexView to perform the layout, with the occassional style property added directly to components to create spacing. This doesn't seem worse than the withStyles strategy unless the components are reusing the same styles (as long as we're mixing data and presentation, a style={...} seems cleaner to me than a class=something tag)

It might makes sense to have explicitly presentational components, or find some other way of separating the style and data.

nikeshnazareth commented 5 years ago

It seems most of the times that I want to add style, it's for spacing that I want to apply to multiple components. The withStyles seems to be cleaner in that scenario so for now, I will just use Flexview and withStyles throughout (until I think of something better)

nikeshnazareth commented 5 years ago

This issue is not particularly actionable.

It's probably better to only use actionable issues to avoid generic thoughts clogging up the todo list.

I will close it for now.