search

two-twelve / tiltime

It's a timer app ⏳
https://tilti.me
1 stars 0 forks source link

Wrap FA icons in <button> #39

Open TheTeaCat opened 2 years ago

TheTeaCat commented 2 years ago

There's a lot of places where buttons are actually just FA icons with tabindexes set on them. These should really be wrapped in a button.

https://github.com/two-twelve/tiltime/pull/34#issuecomment-1179689331

freddyheppell commented 2 years ago

Also, the colour themes picker should just use normal radio buttons. I'd suggest either styling the radio buttons to be black and white, or using hidden radio buttons which are still visible to screenreaders and then fa icons to indicate the status of the hidden radio button.