search

twobin / react-lazyload

Lazy load your component, image or anything matters the performance.
MIT License
5.86k stars 487 forks source link

Replace findDOMNode with ref #242

Closed mmarkelov closed 5 years ago

mmarkelov commented 5 years ago

Fix #209 Use ref callback callback to support versions of React described in package.json

ameerthehacker commented 5 years ago

@mmarkelov looks great thanks for the contribution

mindctrl commented 4 years ago

@ameerthehacker any plans to release this fix on npmjs?

sunknudsen commented 4 years ago

@ameerthehacker findDOMNode has been deprecated for a while and this PR hasn’t made it’s way to NPM. Any change you can publish soon?

ameerthehacker commented 4 years ago

Yup will do it soon

sunknudsen commented 4 years ago

Thanks @ameerthehacker. Much appreciated.

sunknudsen commented 4 years ago

Morning @ameerthehacker. Scheduling a release. I understand open source is a product of love so no rush, but do you have an ETA?

ameerthehacker commented 4 years ago

@sunknudsen thanks for understanding given the pandemic going it had been difficult to get things together, I'm looking for this weekend for a release.

Thanks for your patience

ameerthehacker commented 4 years ago

@sunknudsen v2.6.6 has been released with this change, do check and let me know

sunknudsen commented 4 years ago

Looking good, thanks @ameerthehacker.

wl05 commented 4 years ago

@ameerthehacker cool buddy, thanks

ameerthehacker commented 4 years ago

@antbaobao @sunknudsen unfortunately due to some backward compatibility issues we had to roll back the code to findDomNode, I will probably release a beta version of this first so that this does not happen again, and do help me in testing the beta version

wl05 commented 4 years ago

@ameerthehacker take it easy, it's working fine

ameerthehacker commented 4 years ago

@antbaobao thanks @sunknudsen @antbaobao I have released a beta version to include this change to findDomNode API, please try it as 

npm i react-lazyload@beta

let me know if all the API's you use work fine

kutsan commented 4 years ago

@ameerthehacker Mines work fine FYI.