search

twobin / react-lazyload

Lazy load your component, image or anything matters the performance.
MIT License
5.85k stars 487 forks source link

React 17 support #331

Closed petertenhoor closed 3 years ago

petertenhoor commented 3 years ago

Could you update the React version in the package.json to React 17 please 😄

ameerthehacker commented 3 years ago

Sure @petertenhoor a PR would be very helpful if possible.

magnnus commented 3 years ago

That is NOT accessible on NPM when I install this package. It will warn:

npm WARN react-lazyload@3.1.0 requires a peer of react@^0.14.0 || ^15.0.0 || ^16.0.0 but none is installed. You must install peer dependencies yourself.

Maybe you should release a new Version on NPM.

hinsenchan commented 3 years ago

@ameerthehacker there's an issue with the 3.1.0 release in the Yarn registry. The change that adds React ^17.0.0 to the peer dependency list is not there after installing it.