prop-types needs to be a direct dependency, not dev

twobin / react-lazyload

Lazy load your component, image or anything matters the performance.

MIT License

5.85k stars 487 forks source link

prop-types needs to be a direct dependency, not dev #347

Open stroborobo opened 3 years ago

stroborobo commented 3 years ago

With React 17 their own depencency on prop-types was removed, however it is needed for this package. In #91 this was fixed once, but broke again with 2ee646e42. Now without this being resolved by a direct dep in a peer dep this issue is back.

vndre commented 3 years ago

why is this still an issue? This package is unusable in react 17+ if you are not using proptypes in your project.

rawcomposition commented 3 years ago

Same issue here. Are we supposed to manually install the prop-types package? Seems much simpler to just have it listed as an internal dependency of react-lazyload.