search

twocanoes / xcreds

Open Source Project for Syncing IdP password with macOS login password
BSD 3-Clause "New" or "Revised" License
217 stars 24 forks source link

XCreds 5: Password Change window & login window #234

Closed dstranathan closed 3 weeks ago

dstranathan commented 2 months ago

-Bug? The XCreds menubar app Sign-in window refreshBannerText key doesn't seem to work. I still see the default message: "Your local account password needs to be changed..." even though I have a custom string set for this. Im referring to XCreds menu item > Sign-in...> XCreds Passord Update window

-Feature Request: The "Password Update" window header/title cant be modified. It currently says "XCreds Password Update" . Id prefer to be able to customize this string to remove the word "Xcreds" as my end-users don't know what XCReds is and it would be nice to add my org's name to ensure that users know its not malicious. I think this is slated for XCreds 5?

-Bug? If the Mac is offline, sometimes my org's cached custom "Sign in" wallpaper (menuItemWindowBackgroundImageURL) is not used, rather the XCreds default blue wallpaper is rendered (i.e.: with the XCreds logo in bottom right). I dont see any cached files for this image in /Library/Caches/com.twocanoes.xcreds associated with the URL key.

I have also seen this behavior with the login window overlay a few times: I see the default macOS Sonoma wallpaper when offline, not a cached version of my org's wallpaper (loginWindowBackgroundImageURL). I do see a cached image file as expected in /Library/Caches/com.twocanoes.xcreds. One way to test this is to simply pull Ethernet from a Mac desktop running XCreds and reboot. I see the macOS default wallpaper. Then I plug Ethernet back in and refresh the XCreds overlay. My custom wallpaper renders again. Stating the obvious, but my image is processed via a publically-readable URL -not locally.

twocanoes commented 1 month ago

worked for me. Added:

        <key>refreshBannerText</key>
        <string>abcasdfa asdf asdf asdf asdf asdf as dfads f</string>

image

dstranathan commented 1 month ago

Thanks Tim. I think I see what is happening here. I have a group of test Macs using XCReds 5 in AD only, and a set of Macs testing XCreds 5 with Azure/Entra + AD. On the Azure/Entra Macs, the new<key>refreshBannerText</key> key is working. On the AD Macs it is not. Im using the exact same keys/values on both test group's profiles. Example:

<key>shouldShowRefreshBanner</key>
<true/>
<key>refreshBannerText</key>
<string>Your local account password needs to be updated to match your Stowers cloud password.</string>

Screenshots:

Top = Entra + AD, bottom = AD only

Screenshot 2024-07-17 at 5 39 45 PM Screenshot 2024-07-17 at 5 39 06 PM

Note - Im still on build 7087 (still unpacking my brain from PSU Conf - haven't updated yet!)

Also, semi-related to this topic: I may have misunderstood, but I was thinking that we also would have the ability to remove "XCreds" from the window's title bar (i.e. add our own custom string etc) - users don't really know what XCReds is).

dstranathan commented 4 weeks ago

Update: The new customizable banner string is working as expected. The refreshBannerText key is functioning. Thanks.