twodayslate / NetUtils

WHOIS, DNS, ping, view source, and more!
https://itunes.apple.com/us/app/netutils/id1434360325?mt=8
Other
35 stars 6 forks source link

Fix safe area observing for example query #124 #126

Closed iphone201988 closed 1 year ago

twodayslate commented 1 year ago

Please rebase

iphone201988 commented 1 year ago

https://we.tl/t-OjRjdFyePK already up to date

twodayslate commented 1 year ago

Does https://twitter.com/natpanferova/status/1590676836488732678?s=46&t=DunNho2WvomMLprYw9b4pw help?

iphone201988 commented 1 year ago

Does https://twitter.com/natpanferova/status/1590676836488732678?s=46&t=DunNho2WvomMLprYw9b4pw help?

If you check this link ,

Background color also given same as I implemented in snippet.

Please check these screenshots: https://we.tl/t-ujdUL7nHMj I have added the code as suggested, but we need to provide the background color.

If background color is not provided it will show as: https://we.tl/t-SS3ovvpGF7

twodayslate commented 1 year ago

This seemed to work for me

diff --git a/ec3730/Views/Host/HostBarView.swift b/ec3730/Views/Host/HostBarView.swift
index 294cbc7..33358a6 100644
--- a/ec3730/Views/Host/HostBarView.swift
+++ b/ec3730/Views/Host/HostBarView.swift
@@ -41,11 +41,6 @@ struct HostBarView: View {
                 Spacer()
             }
         }
-        .background(
-            VisualEffectView(effect: UIBlurEffect(style: .systemMaterial))
-                .ignoresSafeArea(.all, edges: .horizontal)
-        )
-        .ignoresSafeArea()
         .confirmationDialog("Information", isPresented: $showInfo) {
             Button(action: {
                 UIPasteboard.general.string = url.absoluteString
@@ -58,6 +53,10 @@ struct HostBarView: View {
                 Label("Copy Date", systemImage: "doc.on.doc")
             })
         }
+        .background(
+            VisualEffectView(effect: UIBlurEffect(style: .systemMaterial))
+                .ignoresSafeArea()
+        )
     }
 }

diff --git a/ec3730/Views/Host/HostViewSectionFocusView.swift b/ec3730/Views/Host/HostViewSectionFocusView.swift
index 5f2f32d..0062999 100644
--- a/ec3730/Views/Host/HostViewSectionFocusView.swift
+++ b/ec3730/Views/Host/HostViewSectionFocusView.swift
@@ -10,10 +10,18 @@ struct HostViewSectionFocusView: View {
                 ScrollView {
                     HostViewSectionContent(sectionModel: model, canQuery: true)
                 }
-                HostBarView(url: url, date: date)
+                .safeAreaInset(edge: .bottom, spacing: 0) {
+                    HostBarView(url: url, date: date)
+                }
             }
             .navigationTitle(model.service.name)
             .navigationBarTitleDisplayMode(.inline)
         }
     }
 }
+
+struct HostViewSectionFocusViewPreview: PreviewProvider {
+    static var previews: some View {
+        HostViewSectionFocusView(model: WhoisXmlDnsSectionModel(), url: URL(string: "https://google.com")!, date: .now)
+    }
+}
twodayslate commented 1 year ago

It's also used in HostResult.swift

iphone201988 commented 1 year ago

Please Suggest , on which ticket we can work upon next

1.https://github.com/twodayslate/NetUtils/issues/108 Add status progress bar for source view · Issue #108 · twodayslate/NetUtilsgithub.com 2.https://github.com/twodayslate/NetUtils/issues/101 Create Image enum/extension · Issue #101 · twodayslate/NetUtilsgithub.com 3.https://github.com/twodayslate/NetUtils/issues/102 Create UserDefaults extensions · Issue #102 · twodayslate/NetUtilsgithub.com 4.https://github.com/twodayslate/NetUtils/issues/98 Disable navigation to PingSetList if there are no ping sets · Issue #98 · twodayslate/NetUtilsgithub.com 5.https://github.com/twodayslate/NetUtils/issues/82 Hide host lookup bar on scroll · Issue #82 · twodayslate/NetUtilsgithub.com 6.https://github.com/twodayslate/NetUtils/issues/111

iphone201988 commented 1 year ago

It's also used in HostResult.swift

https://we.tl/t-QxHhGQZNh6 This view has tabbar below , please check screenshot, If any updation required let me know.

twodayslate commented 1 year ago

Can that use the safe area unset as well?