twodayslate / swift-package-registry

A Swift Package Registry
https://swiftpkg.dev
ISC License
26 stars 6 forks source link

upgraded dependencies #86

Closed makzpatel closed 1 year ago

grijeshagrawal13 commented 1 year ago

Doc: https://docs.google.com/document/d/1Z8XfizbvHcQ4f4aeKsaupsV0zT4vEXwkevG3xPjrrKQ

grijeshagrawal13 commented 1 year ago

Updated the Doc as well. To resolve the / redirecting issue, we found out that its an issue with the probot run index.js. It will be resolved in v13 as defined here: https://github.com/probot/probot/milestone/6. So, for now, most used solution as suggested by probot devs as well is to use app-name along with the base url.

makzpatel commented 1 year ago
  1. We've recorded a demonstration of our server setup, including how the routes on localhost work and how events triggered from GitHub are logged in our terminal. Check out the link to see it- https://www.loom.com/share/34ea42dace4a4a52ba4547ec08be2678
  2. It appears that the routing issue we're experiencing, where "/" automatically redirects to "/probot," is a known problem that arose with the latest version of Probot. Fortunately, the Probot team has already addressed this issue and included a fix in the upcoming release, version 13. Once this new version is released, the routing problem should be resolved. https://github.com/probot/probot/milestone/6 https://github.com/probot/probot/issues/1576
grijeshagrawal13 commented 1 year ago

We have added patch package to the Probot dependency. Doc has been updated as well: https://docs.google.com/document/d/1Z8XfizbvHcQ4f4aeKsaupsV0zT4vEXwkevG3xPjrrKQ

twodayslate commented 1 year ago

Have to change app.js to work in my server environment.

twodayslate commented 1 year ago

https://probot.github.io/docs/development/#run-probot-programmatically

twodayslate commented 1 year ago

I have submitted a PR in your branch

grijeshagrawal13 commented 1 year ago

We have created this new PR, which includes all the changes: https://github.com/twodayslate/swift-package-registry/pull/88