twofas / 2fas-android

Source code for 2FAS Android app
GNU General Public License v3.0
981 stars 69 forks source link

[Suggestion] Update icons for tokens automatically whenever new icons get added to the app #119

Open dftf-stu opened 8 months ago

dftf-stu commented 8 months ago

Describe the Issue

I recently logged a ticket on here saying that there was no icon for "eBay" inside the 2FAS Android app. Despite that ticket getting closed, and my app receiving an update post-then via the Play Store, my eBay token still just had an orange-circle with "EB" inside as the icon.

I have recently-learned that users have to update this manually: hold-down on the token, tap "Edit", then tap the left-hand option under "Personalization" (the 2FAS red-shield logo), then tap "Change branding"; then, from the next screen, find and select the eBay logo.

Solution or Proposal

Expecting users will know how to (or that they even have to!) manually-update the icons seems odd to me.

Surely whenever new icons get-added for services which previously didn't have them, those icons should just get applied automatically to the tokens listed of that service -- I'd think that's what most-users would logically expect?

KobeW50 commented 8 months ago

whenever new icons get-added for services which previously didn't have them, those icons should just get applied automatically to the tokens listed of that service

This can be done by checking if any of the new/updated icons match any of the user's service names upon app startup (after an update).

However, an issue with this is that it will force users to use the service's logo if they name the service properly. If someone prefers the text/bubble icon this will be annoying.