twofas / 2fas-browser-extension

Source code for 2FAS Browser Extension
https://2fas.com/browser-extension
GNU General Public License v3.0
266 stars 36 forks source link

Autofilling for community.bitwarden.com, forum.torproject.org (discourse?) #42

Closed Tipoff4317 closed 8 months ago

Tipoff4317 commented 9 months ago

Description

Autofilling on the community.bitwarden.com, forum.torjproject.org recycles back to the login page.

Steps to reproduce:

1) community.bitwarden.com (or forum.torproject.org) 2) hit Login 3) Enter email and password 4) On the 2FA page, hit the 2FAS button 5) Approve on the phone 6) All 6 digits filled in, and without having to hit the "Login" button, the page recycles back to the front page without having logged in

Entering the code manually, having to hit the Login button on the page, will login properly.

This is probably related to the Discourse servers.

Platforms:

Windows Pro 11 FF 115.7.0esr (x64 bit) 2FAS FF browser extension: 1.6.1 Android 2FAS: 5.2.0

Comments

Having to get this to work with all the websites is probably a freaking pain. It's a really nice feature, though, and is one of the reasons I use 2FAS instead of Aegis.

GrzegorzZajac000 commented 9 months ago

I will check these sites, but also you can disable auto submit for problematic websites in extension's options.

GrzegorzZajac000 commented 9 months ago

Unfortunately, I tried my best, but I can't fix that problem. I followed how TOTP works in Discourse and created a topic in their community in which I suggested what changes they should make. If they enter them, you will also have to wait until the administrators of individual pages update the script version.

For now, you can only exclude these domains from auto submit feature.

Tipoff4317 commented 8 months ago

Thanks for looking into it. The extension is a brilliant feature that makes life easier!

GrzegorzZajac000 commented 8 months ago

@Tipoff4317 I'm in contact with someone from Discourse, but for now I did a trick that makes the problem no longer occur. v1.6.2 was uploaded to stores. Should be available in near future ;)

Tipoff4317 commented 8 months ago

@GrzegorzZajac000, you are pretty awesome to go that far. Wow.

Thank you!

Tipoff4317 commented 8 months ago

Yeah, confirmed fixed on all the discourse sites I have accounts on.